Support more SHOW ... WHERE #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, somehow I missed this. In my queue for the next hour. |
benesch
approved these changes
Apr 15, 2020
justinj
force-pushed
the
show
branch
3 times, most recently
from
1a021ee
to
699f507
Compare
|
Triggered a rebuild. You hit a known build flakiness issue that's fixed on more recent SHAs. If the rebuild doesn't work, a rebase should. |
Fixes #1529. The only remaining unsupported case is SHOW VIEWS/SOURCES, because we don't plumb down the needed info via the catalog. I got rid of some ordering stuff, I can add it back in the form of a RowSetFinishing, but it doesn't seem to have been tested so I'm not sure it was actually important.
|
@justinj Could you add this to the v0.2.1 release notes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MaterializeInc/database-issues#534.
The only remaining unsupported case is SHOW VIEWS/SOURCES, because we
don't plumb down the needed info via the catalog.
I got rid of some ordering stuff, I can add it back in the form of a
RowSetFinishing, but it doesn't seem to have been tested so I'm not sure
it was actually important.
This change is