Apply suggestions from code review

Co-authored-by: Sculas <contact@sculas.xyz> Co-authored-by: Wing <44992537+wingio@users.noreply.github.com>
MateriiApps · Nov 6, 2023 · ed73cf9 · ed73cf9
1 parent 84cf0a6
commit ed73cf9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt b/ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
@@ -35,11 +35,10 @@ fun RowScope.LargeSegmentedButton(
         horizontalAlignment = Alignment.CenterHorizontally,
         verticalArrangement = Arrangement.spacedBy(12.dp, Alignment.CenterVertically),
         modifier = Modifier
-            .clickable(enabled) { onClick() }
+            .clickable(enabled = enabled, role = Role.Button) { onClick() }
             .background(MaterialTheme.colorScheme.surfaceColorAtElevation(2.dp))
             .weight(1f)
             .padding(16.dp)
-
     ) {
         when (icon) {
             is ImageVector -> {

diff --git a/...rc/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt b/...rc/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
@@ -52,7 +52,7 @@ class RepoDetailsViewModel(
     }
 
     fun starRepo() {
-        updateStarDetails(true)
+        updateStarDetails(starred = true)
 
         coroutineScope.launch {
             isStarLoading = true
@@ -62,7 +62,7 @@ class RepoDetailsViewModel(
                     isStarLoading = false
                 },
                 onError = {
-                    updateStarDetails(false)
+                    updateStarDetails(starred = false)
 
                     isStarLoading = false
                     hasError = true
@@ -72,7 +72,7 @@ class RepoDetailsViewModel(
     }
 
     fun unstarRepo() {
-        updateStarDetails(false)
+        updateStarDetails(starred = false)
 
         coroutineScope.launch {
             isStarLoading = true
@@ -82,7 +82,7 @@ class RepoDetailsViewModel(
                     isStarLoading = false
                 },
                 onError = {
-                    updateStarDetails(true)
+                    updateStarDetails(starred = true)
 
                     isStarLoading = false
                     hasError = true