Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback/Suggestions: (feat: File Viewing) #34

Closed
DarkCrypt opened this issue Nov 15, 2023 · 2 comments
Closed

Feedback/Suggestions: (feat: File Viewing) #34

DarkCrypt opened this issue Nov 15, 2023 · 2 comments

Comments

@DarkCrypt
Copy link

Referencing to PR #29.

Gestures

Double tap to show/hide ui

  • Remove: Unnecessary feature. This can also be a pain for users if they attempt to select individual lines too quickly.

Selecting lines

  • Add: Single press within a selection to deselect.

Pinch to zoom in/out

  • Needs to be more responsive with text files. Images zoom perfectly.

Toolbar Options

  • Add: Download any file. (Not just certain ones).
  • Add: Wrap lines.
  • Add: File history.
  • Add: Print option.
  • Add: Text search within a file.
  • Add: Open in browser. (Share function can already achieve same result).
@wingio
Copy link
Member

wingio commented Nov 15, 2023

Im not gonna remove double tap to hide ui, but i could make it something you have to enable

Zooming with text just works differently, doing the same kind of zoom that images use negatively effected scrolling

Unfortunately i couldn't retrieve any link to a raw file for text/md, so downloading isn't an option rn

The rest are already planned but i just wanted to do in a separate pr

@DarkCrypt
Copy link
Author

Understood. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants