Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) File viewing #29

Merged
merged 9 commits into from
Nov 13, 2023
Merged

(feat) File viewing #29

merged 9 commits into from
Nov 13, 2023

Conversation

wingio
Copy link
Member

@wingio wingio commented Oct 2, 2023

  • View markdown files
    • Swap to raw view
  • View text files
    • Syntax highlighting
    • Select lines
    • Scroll bar
    • Zoom
  • View image files
    • Pinch to zoom
    • Download images
  • View PDFs
    • Download PDFs

- Dynamically size the line number instead of using constant value
- Make all lines the same width to prevent jumping when scrolling
- Optimize more values
@DarkCrypt DarkCrypt mentioned this pull request Oct 31, 2023
@oSumAtrIX
Copy link
Contributor

A huge QoL feature that the official mobile GitHub app lacks, which is a deal breaker for me at least, is the ability to pinch to zoom in or out of the code. You are limited to view the code, line wrapped or not, at a certain font size, but sometimes, you may want to look at a part of the file more closely or see a big overview of the file. Web browsers allow to zoom into sites, including the file viewer of GitHub which is effectively what Materii may want to support natively.

@wingio
Copy link
Member Author

wingio commented Oct 31, 2023

Oh yeah someone had requested that on discord, guess i forgot to add it to the todo list

@ghost
Copy link

ghost commented Nov 4, 2023

A search button for files would also be nice!

@wingio
Copy link
Member Author

wingio commented Nov 4, 2023

A search button for files would also be nice!

Like being able to search within a file?

@ghost
Copy link

ghost commented Nov 4, 2023

A search button for files would also be nice!

Like being able to search within a file?

like being able to search for a file.

@wingio
Copy link
Member Author

wingio commented Nov 4, 2023

A search button for files would also be nice!

Like being able to search within a file?

like being able to search for a file.

unfortunately githubs api doesn't seem to support that, best i could do is search only within a directory

@ghost
Copy link

ghost commented Nov 4, 2023

A search button for files would also be nice!

Like being able to search within a file?

like being able to search for a file.

unfortunately githubs api doesn't seem to support that, best i could do is search only within a directory

ah ok!

- Double tap to show/hide ui
- Long press to start selection
- Single press while in a selection to select more
- Pinch to zoom (min 70%, max 200%)
@wingio wingio marked this pull request as ready for review November 13, 2023 22:27
@wingio wingio merged commit 348a1f5 into main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants