-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates and tests #29
Conversation
gpetretto
commented
Oct 7, 2022
- Tests for the ecp option in define (unit and integration), plus validation and update default templates
- more handled cases for set basis and ecp in define
- fix Problem with pexpect in define.py #25
- few more small fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I did not try the feature itself as I'm not an expert. Maybe we can ask the initial PR author to test and provide feedback (could even be after merge, e.g. setting that feature as experimental for now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me!