Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates and tests #29

Merged
merged 10 commits into from
Jan 26, 2023
Merged

updates and tests #29

merged 10 commits into from
Jan 26, 2023

Conversation

gpetretto
Copy link
Contributor

  • Tests for the ecp option in define (unit and integration), plus validation and update default templates
  • more handled cases for set basis and ecp in define
  • fix Problem with pexpect in define.py #25
  • few more small fix

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I did not try the feature itself as I'm not an expert. Maybe we can ask the initial PR author to test and provide feedback (could even be after merge, e.g. setting that feature as experimental for now).

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@gpetretto gpetretto merged commit 60cb5dd into Matgenix:ecp Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants