Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in cell_rules.csv #172

Closed
wants to merge 1 commit into from

Conversation

drbergman
Copy link
Collaborator

It seems there should be a comma in Line 27 in "decreases migration speed". That would make it fit with the syntax in all the other rows.

It seems there should be a comma in Line 27 in "decreases migration speed". That would make it fit with the syntax in all the other rows.
@rheiland
Copy link
Collaborator

In fact, I believe there are 2 missing commas in that .csv. I'd previously replied to a user on the slack channel about this (but probably should have copied the entire #general channel).
https://physicellcomm-sf93727.slack.com/archives/C022E5T2DT5/p1689269847408089?thread_ts=1689266514.730889&cid=C022E5T2DT5

I think I also submitted a Issue about it, just to jog our memory.

@drbergman
Copy link
Collaborator Author

well shoot...Now I just feel like I gave you extra work. 🤦 Glad it's been flagged already 😄

@rheiland
Copy link
Collaborator

This (complete) fix is now included in this PR #149 . And as a heads up to Daniel, I don't believe his fix above, where he inserted a comma into the .csv, would have made it through the PhysiCell parsing since (I think) he had a space after the comma which is not allowed. Or maybe I just imagined a space was there.

@MathCancer
Copy link
Owner

Thank you! I"m informed that 149 incorporates this fix. Thank you!!

@MathCancer MathCancer closed this Jul 26, 2023
@drbergman drbergman deleted the patch-3 branch July 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants