Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing deprecated function toECDSAPub #1

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Replacing deprecated function toECDSAPub #1

merged 1 commit into from
Aug 8, 2018

Conversation

MathieuGilbert
Copy link
Owner

Resolves:

> go test ./...
# github.com/coincircle/go-etherdelta
../../coincircle/go-etherdelta/etherdelta.go:602:12: undefined: "github.com/ethereum/go-ethereum/crypto".ToECDSAPub

@MathieuGilbert
Replacing deprecated function toECDSAPub
6c86b9e 
- Replaced crypto.toECDSAPub with crypto.UnmarshalPubKey, based on ethereum/go-ethereum#16932
- Skipping failing test (test token isn't in live results).
@MathieuGilbert MathieuGilbert merged commit 474cd4a into master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MathieuGilbert