Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy with actions artifact #82

Merged
merged 2 commits into from
May 15, 2024
Merged

feat: deploy with actions artifact #82

merged 2 commits into from
May 15, 2024

Conversation

brenoepics
Copy link
Contributor

image
closes #71

@brenoepics
Copy link
Contributor Author

Also, type, options have been removed from the yml because they are not valid.

Copy link
Owner

@MathieuSoysal MathieuSoysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looks good to me, thank you and congratulation for this contribution 🥳

Do you have any source that proof the type and options are no longer used by Github Action ?

@brenoepics
Copy link
Contributor Author

Hi, thanks.
the official docs does not mention these options for creating actions and the official VsCode/JetBrains WebStorm plugin warns that they are not part of the syntax in fact they can be used in workflows but not in action.yml

I also took a look at some other actions and realized that they don't have this in the inputs, I was also looking at the toolkit because I'm working on a Java version of it and it treats all inputs as string and parse to see if it is a boolean, multiline, or string.
composite actions like javadoc-publisher doesn't have parsing at all

@MathieuSoysal
Copy link
Owner

Thank for your help and your answer 🔥

What do you think @pSub

@MathieuSoysal MathieuSoysal merged commit 0a7e84c into MathieuSoysal:main May 15, 2024
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: GitHub Action Deployment
2 participants