Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [Inject] to ZenjectSceneLoader Constructor #41

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add [Inject] to ZenjectSceneLoader Constructor #41

merged 1 commit into from
Jul 27, 2022

Conversation

zb-sj
Copy link

@zb-sj zb-sj commented Jun 8, 2022

Inject Attribute is required for ConstructorChoiceStrategy.InjectAttribute

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • No compiler errors or warnings

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Issue Number

Issue Number: N/A

What is the current behavior?

  • Validation fails and won't play with Zenject.ZenjectSceneLoader

ArgumentException: Type 'Zenject.ZenjectSceneLoader' does not have a default constructor

What is the new behavior?

  • Validation passes and play as expected

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • 9.3.0 UPM Environmnet
  • There might be other places which requires Inject Attribute

On which Unity version has this been tested?

  • 2020.4 LTS
  • 2020.3
  • 2020.2
  • 2020.1
  • 2019.4 LTS
  • 2019.3
  • 2019.2
  • 2019.1
  • 2018.4 LTS

Scripting backend:

  • Mono
  • IL2CPP

Inject Attribute  is required for `ConstructorChoiceStrategy.InjectAttribute`
@Mathijs-Bakker Mathijs-Bakker merged commit 4a05ef1 into Mathijs-Bakker:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants