fix: general fixes for connecting to seed node

Fixes #489

src/config.ts

@@ -83,14 +83,14 @@ const config = {
       clientPort: 0 as Port,
     },
     proxyConfig: {
-      connConnectTime: 20000,
+      connConnectTime: 2000,
       connKeepAliveTimeoutTime: 20000,
       connEndTime: 1000,
       connPunchIntervalTime: 1000,
       connKeepAliveIntervalTime: 1000,
     },
     nodeConnectionManagerConfig: {
-      connConnectTime: 20000,
+      connConnectTime: 2000,
       connTimeoutTime: 60000,
       initialClosestNodes: 3,
     },

src/network/ConnectionForward.ts

@@ -111,6 +111,9 @@ class ConnectionForward extends Connection {
   }
 
   public async start({ ctx }: { ctx: ContextTimed }): Promise<void> {
+    if (ctx.timer.getTimeout() >= 20000) {
+      throw new networkErrors.ErrorConnectionStartTimeoutMax();
+    }
     this.logger.info('Starting Connection Forward');
     // Promise for ready
     const { p: readyP, resolveP: resolveReadyP } = promise<void>();
@@ -122,7 +125,15 @@ class ConnectionForward extends Connection {
     // Promise for abortion and timeout
     const { p: abortedP, resolveP: resolveAbortedP } = promise<void>();
     if (ctx.signal.aborted) {
-      resolveAbortedP();
+      this.logger.info(`Forward was aborted with: ${ctx.signal.reason}`);
+      // This is for arbitrary abortion reason provided by the caller
+      // Re-throw the default timeout error as a network timeout error
+      if (
+        ctx.signal.reason instanceof contextsErrors.ErrorContextsTimedTimeOut
+      ) {
+        throw new networkErrors.ErrorConnectionStartTimeout();
+      }
+      throw ctx.signal.reason;
     } else {
       ctx.signal.addEventListener('abort', () => resolveAbortedP());
     }
@@ -159,7 +170,7 @@ class ConnectionForward extends Connection {
         await this.send(networkUtils.pingBuffer);
       }, this.punchIntervalTime);
       await Promise.race([
-        Promise.all([readyP, secureConnectP]).then(() => {}),
+        Promise.all([readyP, secureConnectP]),
         errorP,
         abortedP,
       ]);
@@ -171,12 +182,7 @@ class ConnectionForward extends Connection {
         this.tlsSocket.destroy();
       }
       this.utpSocket.off('message', this.handleMessage);
-      throw new networkErrors.ErrorConnectionStart(e.message, {
-        data: {
-          code: e.code,
-          errno: e.errno,
-          syscall: e.syscall,
-        },
+      throw new networkErrors.ErrorConnectionStart(undefined, {
         cause: e,
       });
     } finally {
@@ -192,6 +198,8 @@ class ConnectionForward extends Connection {
         this.tlsSocket.destroy();
       }
       this.utpSocket.off('message', this.handleMessage);
+      // This is for arbitrary abortion reason provided by the caller
+      // Re-throw the default timeout error as a network timeout error
       if (
         ctx.signal.reason instanceof contextsErrors.ErrorContextsTimedTimeOut
       ) {

src/network/ConnectionReverse.ts

@@ -109,6 +109,9 @@ class ConnectionReverse extends Connection {
   }
 
   public async start({ ctx }: { ctx: ContextTimed }): Promise<void> {
+    if (ctx.timer.getTimeout() >= 20000) {
+      throw new networkErrors.ErrorConnectionStartTimeoutMax();
+    }
     this.logger.info('Starting Connection Reverse');
     // Promise for ready
     const { p: readyP, resolveP: resolveReadyP } = promise<void>();
@@ -118,7 +121,19 @@ class ConnectionReverse extends Connection {
     const { p: errorP, rejectP: rejectErrorP } = promise<void>();
     // Promise for abortion and timeout
     const { p: abortedP, resolveP: resolveAbortedP } = promise<void>();
-    ctx.signal.addEventListener('abort', () => resolveAbortedP());
+    if (ctx.signal.aborted) {
+      this.logger.info(`Reverse was aborted with: ${ctx.signal.reason}`);
+      // This is for arbitrary abortion reason provided by the caller
+      // Re-throw the default timeout error as a network timeout error
+      if (
+        ctx.signal.reason instanceof contextsErrors.ErrorContextsTimedTimeOut
+      ) {
+        throw new networkErrors.ErrorConnectionStartTimeout();
+      }
+      throw ctx.signal.reason;
+    } else {
+      ctx.signal.addEventListener('abort', () => resolveAbortedP());
+    }
     this.resolveReadyP = resolveReadyP;
     this.utpSocket.on('message', this.handleMessage);
     this.serverSocket = net.connect(this.serverPort, this.serverHost, () => {
@@ -151,12 +166,7 @@ class ConnectionReverse extends Connection {
       // Socket isn't established yet, so it is destroyed
       this.serverSocket.destroy();
       this.utpSocket.off('message', this.handleMessage);
-      throw new networkErrors.ErrorConnectionStart(e.message, {
-        data: {
-          code: e.code,
-          errno: e.errno,
-          syscall: e.syscall,
-        },
+      throw new networkErrors.ErrorConnectionStart(undefined, {
         cause: e,
       });
     } finally {
@@ -169,7 +179,14 @@ class ConnectionReverse extends Connection {
       // Socket isn't established yet, so it is destroyed
       this.serverSocket.destroy();
       this.utpSocket.off('message', this.handleMessage);
-      throw new networkErrors.ErrorConnectionStartTimeout();
+      // This is for arbitrary abortion reason provided by the caller
+      // Re-throw the default timeout error as a network timeout error
+      if (
+        ctx.signal.reason instanceof contextsErrors.ErrorContextsTimedTimeOut
+      ) {
+        throw new networkErrors.ErrorConnectionStartTimeout();
+      }
+      throw ctx.signal.reason;
     }
     this.connections.proxy.set(this.address, this);
     this.connections.reverse.set(this.proxyAddress, this);

src/network/Proxy.ts

@@ -60,7 +60,7 @@ class Proxy {
 
   constructor({
     authToken,
-    connConnectTime = 20000,
+    connConnectTime = 2000,
     connKeepAliveTimeoutTime = 20000,
     connEndTime = 1000,
     connPunchIntervalTime = 50,

src/network/errors.ts

@@ -70,6 +70,12 @@ class ErrorConnectionStartTimeout<T> extends ErrorConnectionStart<T> {
   exitCode = sysexits.NOHOST;
 }
 
+class ErrorConnectionStartTimeoutMax<T> extends ErrorConnectionStart<T> {
+  static description =
+    'Connection start timeout exceeds max allowable of 20 seconds';
+  exitCode = sysexits.USAGE;
+}
+
 /**
  * Used by ConnectionReverse
  */
@@ -144,6 +150,7 @@ export {
   ErrorConnectionEndTimeout,
   ErrorConnectionStart,
   ErrorConnectionStartTimeout,
+  ErrorConnectionStartTimeoutMax,
   ErrorConnectionCompose,
   ErrorConnectionComposeTimeout,
   ErrorCertChain,

src/nodes/NodeConnectionManager.ts

@@ -97,7 +97,7 @@ class NodeConnectionManager {
     taskManager,
     seedNodes = {},
     initialClosestNodes = 3,
-    connConnectTime = 20000,
+    connConnectTime = 2000,
     connTimeoutTime = 60000,
     pingTimeout = 2000,
     logger,

src/tasks/TaskManager.ts

@@ -940,13 +940,6 @@ class TaskManager {
         );
         await this.gcTask(taskId, tran);
         tran.queueSuccess(() => {
-          // THIS only runs after the transaction is committed
-          // IS IT POSSIBLE
-          // that I HAVE REGISTERED EVENT HANDLERS is at there
-          // cause if so, it would then be able to
-          // to get an event listener registered
-          // only afterwards
-
           this.taskEvents.dispatchEvent(
             new TaskEvent(taskIdEncoded, {
               detail: {