Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated @matrixai/errors and setup error chaining #14

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

CMCDragonkai
Copy link
Member

Description

This integrates the new @matrixai/errors here.

We've added the static descriptions to each error here in the src/errors.ts.

Additionally all extended errors preserve the generic parameter, so that by default it's typed to unknown.

There's no exit code here because this is a library, and exit codes are for applications which will be handled by PK.

Issues Fixed

Tasks

  • 1. Added @matrixai/errors
  • 2. Added static error descriptions
  • 3. Changed to using error chain

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai self-assigned this Apr 5, 2022
@CMCDragonkai
Copy link
Member Author

This will be a minor upgrade, no API guarantee is on the errors atm.

@CMCDragonkai CMCDragonkai merged commit 71b020e into master Apr 5, 2022
@CMCDragonkai CMCDragonkai deleted the errors branch April 5, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant