-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating continuous benchmarking from js-logger #47
Conversation
* Updated dependencies to match * Using the new `--arg ci true` for `nix-shell`
👇 Click on the image for a new way to code review
Legend |
Here are the differences from the previous benchmark. This is run with
The main thing to see here is that puts have become much faster 1.59x faster, while gets are getting back similar to leveldb speeds. Prior leveldb was even using the boosted CPU. I suspect the biggest speed at this point will be due to usage of native transactions inside rocksdb, however I have not started measuring transactions yet. Also note that these are unencrypted performance. Encryption is not involved here because it will seriously affect the speed until we move to using native crypto. Further benchmarking can be done with DB plus crypto subsequently. |
@tegefaulkes see benchmark data above. |
Error indicates that |
Just updated
As a side-note efs also needs |
Permissions updated, you should be able to push protected tags to js-logger now. |
1.3.5 of js-workers is being staged. |
Going to merge now, and do the rest in |
Description
This brings in some synchronisation with js-logger and continuous benchmarking
Issues Fixed
Tasks
.gitlab-ci.yaml
to run benchmarksnix-shell --arg ci true --run $''
to ensure strict error checking AND also allow C-style string escapingts-node
to usingswc
Final checklist