Skip to content

Commit

Permalink
Remove a deprecated multibyte_split API (rapidsai#16501)
Browse files Browse the repository at this point in the history
Removes overloaded `cudf::io::text::multibyte_split` API deprecated in 24.08 and is no longer needed.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#16501
  • Loading branch information
davidwendt authored Aug 9, 2024
1 parent 2c8de62 commit 9ec34ad
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 34 deletions.
20 changes: 0 additions & 20 deletions cpp/include/cudf/io/text/multibyte_split.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,6 @@ std::unique_ptr<cudf::column> multibyte_split(
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/**
* @brief Splits the source text into a strings column using a multiple byte delimiter.
*
* @deprecated Since 24.08
*
* @param source The source input data encoded in UTF-8
* @param delimiter UTF-8 encoded string for which to find offsets in the source
* @param byte_range The position and size within `source` to produce the column from
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Memory resource to use for the device memory allocation
* @return The strings found by splitting the source by the delimiter within the relevant byte
* range.
*/
[[deprecated]] std::unique_ptr<cudf::column> multibyte_split(
data_chunk_source const& source,
std::string const& delimiter,
std::optional<byte_range_info> byte_range,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/** @} */ // end of group

} // namespace text
Expand Down
14 changes: 0 additions & 14 deletions cpp/src/io/text/multibyte_split.cu
Original file line number Diff line number Diff line change
Expand Up @@ -567,20 +567,6 @@ std::unique_ptr<cudf::column> multibyte_split(cudf::io::text::data_chunk_source

} // namespace detail

// deprecated in 24.08
std::unique_ptr<cudf::column> multibyte_split(cudf::io::text::data_chunk_source const& source,
std::string const& delimiter,
std::optional<byte_range_info> byte_range,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
return multibyte_split(source,
delimiter,
parse_options{byte_range.value_or(create_byte_range_info_max())},
stream,
mr);
}

std::unique_ptr<cudf::column> multibyte_split(cudf::io::text::data_chunk_source const& source,
std::string const& delimiter,
parse_options options,
Expand Down

0 comments on commit 9ec34ad

Please sign in to comment.