support leesei/logcat.tmLanguage #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original ADB was based on [quarnster/ADBView](https://github.com/quarnster/ADBView). I've written another syntax (with better scopes) at [leesei/logcat.tmLanguage](https://github.com/leesei/logcat.tmLanguage). Also updated WARN's highlight.
|
Thanks for the PR, and I apologize for not checking it out sooner. Your additions look fine, but I'd still like to support ADBView for those who haven't changed to your version. Could you modify your changes so that both sets of scopes still work? For example, Thanks! |
|
I see. I will create a new PR that merges my several updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original ADB was based on quarnster/ADBView.
I've written another syntax (with better scopes) at leesei/logcat.tmLanguage.
Also updated WARN's highlight.