Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New improvements and test cases #27

Merged
merged 36 commits into from
Aug 12, 2024

Conversation

MattKeeley
Copy link
Owner

Merge Request Description

This merge request addresses several key improvements and enhancements:

  1. Resolved False Negatives in Issue Spoofing not possible without SPF or DMARC record. #26:

  2. Program Modularization:

    • Refactored the process_domain function to be more modular, enabling its use as a library in other tools.
  3. BIMI Record Resolver Cleanup:

    • Improved the clarity and efficiency of the BIMI record resolver.
  4. Test Case Enhancements:

    • Developed clearer and more readable test cases, ensuring better coverage and easier maintenance.
  5. New Logic for DMARC and SPF Records:

    • Added logic to handle DMARC and SPF records with broken syntax, addressing potential spoofing vulnerabilities.
  6. Syntax Validation Class:

    • Introduced a SyntaxValidator class to ensure SPF and DMARC records conform to RFC syntax requirements before evaluation.
  7. Threading Support:

    • Added a -t option for threading, allowing for more efficient processing of multiple records.

@MattKeeley MattKeeley linked an issue Aug 12, 2024 that may be closed by this pull request
@MattKeeley MattKeeley merged commit 31e4ade into main Aug 12, 2024
1 check passed
@MattKeeley MattKeeley deleted the 26-spoofing-not-possible-without-spf-or-dmarc-record branch August 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spoofing not possible without SPF or DMARC record.
1 participant