Skip to content

Commit

Permalink
Drop support for Python < 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
MatteoH2O1999 committed Dec 11, 2024
1 parent 523ec52 commit 26edde7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/create_python_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
splits = short_tag.split('.')
major = int(splits[0])
minor = int(splits[1])
if major == 3 and minor >= 7 and short_tag not in json_dict['python-version']:
if major == 3 and minor >= 8 and short_tag not in json_dict['python-version']:
json_dict['python-version'].append(short_tag)

with open(os.environ['GITHUB_OUTPUT'], 'a') as fh:
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ For a more complete view on the actions see [action.yml](action.yml) or look in
In general you could replace the original action with this one and it should already work (all its supported inputs are also supported in this one):

```yaml
- uses: MatteoH2O1999/setup-python@v4
- uses: MatteoH2O1999/setup-python@v5
with:
python-version: '3.8'
```
But if you wish for a more optimized experience you could use inputs exclusive to this action:
```yaml
- uses: MatteoH2O1999/setup-python@v4
- uses: MatteoH2O1999/setup-python@v5
with:
python-version: '3.8'
allow-build: info
Expand All @@ -55,9 +55,9 @@ Older versions may still work, but no effort will be spent in ensuring so.

## Guarantees

The objective of this action is to guarantee that for every major Python version starting from `3.7` at least one specific version can be successfully installed on the `...-latest` images using the default architecture.
The objective of this action is to guarantee that for every major Python version starting from `3.8` at least one specific version can be successfully installed on the `...-latest` images using the default architecture.

TLDR: If you use the major version specification (`3.7` instead of `3.7.5`) without specifying the architecture as shown in [Basic usage](#basic-usage) this action is guaranteed to work (hopefully...😉) on all the `...-latest` labels.
TLDR: If you use the major version specification (`3.8` instead of `3.8.5`) without specifying the architecture as shown in [Basic usage](#basic-usage) this action is guaranteed to work (hopefully...😉) on all the `...-latest` labels.

## Known limits

Expand Down

0 comments on commit 26edde7

Please sign in to comment.