Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

= Fix broken HTML & CSS #23

Merged
merged 1 commit into from
Feb 25, 2021
Merged

= Fix broken HTML & CSS #23

merged 1 commit into from
Feb 25, 2021

Conversation

tetreum
Copy link
Contributor

@tetreum tetreum commented Feb 23, 2021

Uf.....
The way this template got setup makes it impossible to maintain. I understand that because of aMule's PHP, we can't do things like including/requiring in php to avoid duplicated content but what about styles??
Why weren't they placed on a styles.css rather than duplicating them everywhere?

Anyway, i fixed multiple broken styles and html.
Like:
1

Which now looks:
2

Closes #22 , #21

@MatteoRagni
Copy link
Owner

MatteoRagni commented Feb 25, 2021

Because when I made it amule gave 404 on everything that is not in the original server.
But feel free to improve it.

@MatteoRagni MatteoRagni merged commit e872f67 into MatteoRagni:master Feb 25, 2021
@tetreum
Copy link
Contributor Author

tetreum commented Feb 25, 2021

Quite strange.
I didn't have any problem creating and using a styles.css. The real problem was that there were slightly differences between all <style> across the files. So i rolledback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search text in italian
2 participants