Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs are hidden when they only consist of groups of properties #11

Closed
davidstroem opened this issue Oct 30, 2023 · 2 comments
Closed

Tabs are hidden when they only consist of groups of properties #11

davidstroem opened this issue Oct 30, 2023 · 2 comments

Comments

@davidstroem
Copy link

If you create a tab with groups of properties, the tab is hidden by this package. There should be a check for !Tabs.Properties.Any() before looping through properties and checking features.

image

CMS: 12.2.0

Our.FeatureFlags: Latest version

@Matthew-Wise
Copy link
Owner

Thanks @davidstroem, I will need to take a look at this, as I need to work out if its possible to hide the tab if the group has no properties.

Matthew-Wise added a commit that referenced this issue Dec 22, 2023
Bugfix for #11 and added support for v13
@Matthew-Wise
Copy link
Owner

Hi @davidstroem

A little more delayed than I wanted but version 2.1.0 is now out with a fix for this - https://www.nuget.org/packages/Our.FeatureFlags/2.1.0 along with updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants