Skip to content

Commit

Permalink
doc: update labels info in onboarding-extras.md
Browse files Browse the repository at this point in the history
Remove information duplicated in onboarding.md. Organize label list for
clarity. Remove `deps` label which we don't actually have.

PR-URL: nodejs#19160
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MayaLekova committed May 8, 2018
1 parent 367947b commit 1a22b77
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions doc/onboarding-extras.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.

### By Subsystem

We generally sort issues by a concept of "subsystem" so that we know what
part(s) of the codebase it touches.
Subsystems include:

**Subsystems generally are**:
* `lib/*.js` (`assert`, `buffer`, etc.)
* `build`
* `doc`
* `lib / src`
* `test`
* `tools`

* `lib/*.js`
* `doc`, `build`, `tools`, `test`, `deps`, `lib / src` (special), and there may
be others.
* `meta` for anything non-code (process) related

There may be more than one subsystem valid for any particular issue / PR.
There may be more than one subsystem valid for any particular issue or pull
request.

### General

Expand All @@ -72,6 +72,7 @@ Please use these when possible / appropriate
* `discuss` - Things that need larger discussion
* `feature request` - Any issue that requests a new feature (usually not PRs)
* `good first issue` - Issues suitable for newcomers to process
* `meta` - For issues whose topic is governance, policies, procedures, etc.

--

Expand Down

0 comments on commit 1a22b77

Please sign in to comment.