Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo that caused cpp_dummy_build not to be built with CMake #9561

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix typo that caused cpp_dummy_build not to be built with CMake #9561

merged 1 commit into from
Sep 12, 2024

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Sep 11, 2024 •
edited
Loading

Found by Tom.

PR checklist

  • changelog not required because: test only
  • development PR here
  • framework PR not required
  • 3.6 PR not required (typo not present in 3.6)
  • 2.28 PR not required because: code added in 3.6
  • tests provided

@gilles-peskine-arm
Fix typo that caused cpp_dummy_build not to be built with CMake
236e05d 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests component-test Test framework and CI scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Sep 11, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 11, 2024
Merged
6 tasks
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Sep 12, 2024
@gilles-peskine-arm
Copy link
Contributor Author

The typo is not present in 3.6 (f5db72b). It wasn't in the original forward-port (5bb03cc) but it snuck in when I rebased that on top of the splitting of all.sh components into separate files.

paul-elliott-arm
paul-elliott-arm approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Sep 12, 2024
Merged via the queue into Mbed-TLS:development with commit 2f620f3 Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
component-test Test framework and CI scripts needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @paul-elliott-arm @tom-cosgrove-arm