Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Irrelevant Components for 4.0 #9815

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Remove Irrelevant Components for 4.0 #9815

wants to merge 1 commit into from

Conversation

Harry-Ramsey
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey commented Dec 2, 2024 •
edited
Loading

This commit removes irrelevant components that are no longer needed in the 4.0 release. Closes #9807.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required.
  • development PR provided.
  • framework PR not required.
  • 3.6 PR not required because: for release 4.0.
  • 2.28 PR not required because: for release 4.0.
  • tests not required.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@Harry-Ramsey
Remove irrelevant components
c0dd3e4 
This commit removes irrelevant components that are no longer needed in
the 4.0 release.

Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
@Harry-Ramsey Harry-Ramsey self-assigned this Dec 2, 2024
@Harry-Ramsey Harry-Ramsey added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) labels Dec 2, 2024
@eleuzi01
Copy link
Contributor

I could probably review this but is there an issue or something that would let me know based on what criteria the components were removed? Was there a list or something like that?

@Harry-Ramsey
Copy link
Contributor Author

Harry-Ramsey commented Dec 17, 2024 •
edited
Loading

I could probably review this but is there an issue or something that would let me know based on what criteria the components were removed? Was there a list or something like that?

Sorry, I forgot to include the issue number. I have now added that to the message at the start.

eleuzi01
eleuzi01 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleuzi01 eleuzi01 eleuzi01 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@Harry-Ramsey Harry-Ramsey

Labels
enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove some now unrelevant components in components-configuration-crypto.sh
2 participants
@Harry-Ramsey @eleuzi01