Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some information to the README.md file for building this on Fedora 28 #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artorius
Copy link

No description provided.

artorius added 2 commits July 26, 2018 14:05
added a PNG icon and updated the README.md to include instructions fo…
@LukePulverenti
Copy link
Member

Thanks. I'll look at this soon. We have actually customized node-mpv, so I'm not quite sure that using the original is going to work.

@artorius
Copy link
Author

No worries. I used the original from npm on my Fedora system. It seems to work ok (a little laggy) but I'll remove the one I installed and try your custom one next. If it works ok then I'll be sure to update the README to skip the installation of that module.

@LukePulverenti
Copy link
Member

The other thing is we haven't looked the original lib in about a year so it's possibly worth re-evaluation to see if we can just go back to that, but of course that will require code changes.

@artorius
Copy link
Author

I'm about to go out of town for the weekend, so I can definitely beat on my installation to see how it performs with the lib from npm. I'll let you know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants