This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Dependencies update : fix security issues #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2.1.14 version [has some vulnerabilities](https://snyk.io/test/npm/phantomjs-prebuilt/2.1.14) that can be fixed by updating the npm dependencies. This PR fixes : * 1 *Uninitialized Memory Exposure* : updated `extract-zip@1.5.0` to version _1.6.5_ * 1 *Uninitialized Memory Exposure* : updated `request@2.79.0` to version _2.81.0_ ([change log](https://github.com/request/request/blob/master/CHANGELOG.md#v2810-20170309))
Closed
|
@nicks Can you please have a look? Services that catch security vulnerabilities like VersionEye prevent us from using projects that depend on phantomjs because of this issue. |
|
@adrianlee44 @eduardoramirez @jfuchs Can one of you have a look? 🙏 or tag the appropriate person to handle merging this fix |
jfuchs
approved these changes
Aug 10, 2017
|
Thank you for merging this @jfuchs ! Can you please also bump the patch version number in I can make a PR for that if you like. |
|
That'd be great, yes. (As you might've guessed, this isn't under active development, sorry). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2.1.14 version has some vulnerabilities that can be fixed by updating the npm dependencies.
This PR fixes :
extract-zip@1.5.0to version 1.6.5request@2.79.0to version 2.81.0 (change log)Fixes : #728