[CHORE] Entity 필드 Notnull 옵션 제거 및 primitive 타입 사용 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goder-0
added
Priority: Low
mikekks
approved these changes
Feb 23, 2024
Comment on lines
+81
to
+82
| //최대학점 | ||
| private double maxGpa = 4.5; |
There was a problem hiding this comment.
요기 데이터는 지금 당장 사용하는 데이터인가요?? 아니면 나중을 생각하고 만드신 부분일까요??
There was a problem hiding this comment.
저희 UI가 최대 학점이 되어있다고 생각되어 필요한 정보라고 생각했는데요! 혹시 어떻게 생각하시나요?
There was a problem hiding this comment.
아하 넵 좋은 것 같습니다. 4.3은 나중에 고려하도록 하죠..ㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📝 반영 브랜치
📝 변경 사항
다음과 같은 기준으로 변경하였습니다.
@ColumnDefault유지, java Default Value 사용@DynamicInsert제거📝 테스트 결과
테스트는 따로 하지 않았습니다.
📝 To Reviewer
프론트 분들께 Enum에 관하여 여쭤본 결과 한글로 보다 직관적인 것이 좋다고 말씀하셔서 name 필드를 추가하였습니다.
추후, ResponseDto에서도 String 타입으로 제공해야 할 것 같습니다.