Merge pull request #107 from Meesho/fix-transactions-orderby

Fetch transactions with requestDate newest to oldest
Meesho · Apr 8, 2024 · 171e197 · 171e197
2 parents 05fa5e7 + cb849dc
commit 171e197
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/library/src/main/kotlin/com/chuckerteam/chucker/api/Chucker.kt b/library/src/main/kotlin/com/chuckerteam/chucker/api/Chucker.kt
@@ -87,7 +87,7 @@ public object Chucker {
 
     public suspend fun generateHar(context: Context, transactionsLimit: Int = 1000): ByteArray {
         val transactions: List<HttpTransaction> =
-            RepositoryProvider.transaction().getTransactions(transactionsLimit)
+            RepositoryProvider.transaction().getLastTransactions(transactionsLimit)
         val sharable = TransactionDetailsHarSharable(
             content = HarUtils.harStringFromTransactions(
                 transactions,

diff --git a/...lin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionDatabaseRepository.kt b/...lin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionDatabaseRepository.kt
@@ -43,5 +43,5 @@ internal class HttpTransactionDatabaseRepository(private val database: ChuckerDa
 
     override suspend fun getAllTransactions(): List<HttpTransaction> = transactionDao.getAll()
 
-    override suspend fun getTransactions(limit: Int): List<HttpTransaction> = transactionDao.getN(limit)
+    override suspend fun getLastTransactions(limit: Int): List<HttpTransaction> = transactionDao.getLastN(limit)
 }
diff --git a/...main/kotlin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionRepository.kt b/...main/kotlin/com/chuckerteam/chucker/internal/data/repository/HttpTransactionRepository.kt
@@ -27,5 +27,5 @@ internal interface HttpTransactionRepository {
 
     suspend fun getAllTransactions(): List<HttpTransaction>
 
-    suspend fun getTransactions(limit: Int): List<HttpTransaction>
+    suspend fun getLastTransactions(limit: Int): List<HttpTransaction>
 }
diff --git a/library/src/main/kotlin/com/chuckerteam/chucker/internal/data/room/HttpTransactionDao.kt b/library/src/main/kotlin/com/chuckerteam/chucker/internal/data/room/HttpTransactionDao.kt
@@ -45,6 +45,6 @@ internal interface HttpTransactionDao {
     @Query("SELECT * FROM transactions")
     suspend fun getAll(): List<HttpTransaction>
 
-    @Query("SELECT * FROM transactions LIMIT :limit")
-    suspend fun getN(limit: Int): List<HttpTransaction>
+    @Query("SELECT * FROM transactions ORDER BY requestDate DESC LIMIT :limit")
+    suspend fun getLastN(limit: Int): List<HttpTransaction>
 }