Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIDRPool 2/x] Add controller for CIDRPool CRD #42

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Jun 10, 2024

Contains implementation for CIDRPool controller

@ykulazhenkov ykulazhenkov changed the title Add controller for CIDRPool CRD [CIDRPool 2/x] Add controller for CIDRPool CRD Jun 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 70.076% (-2.0%) from 72.083%
when pulling c6a80a2 on ykulazhenkov:pr-cidr-pool-controller
into 18fc6a0 on Mellanox:main.

pkg/ip/cidr.go Outdated Show resolved Hide resolved
cmd/ipam-controller/app/app_suite_test.go Outdated Show resolved Hide resolved
cmd/ipam-controller/app/app_test.go Outdated Show resolved Hide resolved
cmd/ipam-controller/app/app_test.go Show resolved Hide resolved
cmd/ipam-controller/app/app_test.go Outdated Show resolved Hide resolved
pkg/ipam-controller/controllers/cidrpool/cidrpool.go Outdated Show resolved Hide resolved
pkg/ipam-controller/controllers/node/node.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 70.0% (-2.1%) from 72.083%
when pulling 8693daf on ykulazhenkov:pr-cidr-pool-controller
into 18fc6a0 on Mellanox:main.

Copy link
Collaborator Author

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasrem Thanks again for the reviews. I think I addressed all comments in this PR. Please, take another look

@ykulazhenkov ykulazhenkov requested a review from vasrem June 10, 2024 16:31
@coveralls
Copy link

Coverage Status

coverage: 70.0% (-2.1%) from 72.083%
when pulling 803489b on ykulazhenkov:pr-cidr-pool-controller
into 18fc6a0 on Mellanox:main.

@coveralls
Copy link

Coverage Status

coverage: 70.0% (-2.1%) from 72.083%
when pulling e3b3483 on ykulazhenkov:pr-cidr-pool-controller
into 18fc6a0 on Mellanox:main.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@coveralls
Copy link

Coverage Status

coverage: 70.0% (-0.5%) from 70.538%
when pulling f8465ca on ykulazhenkov:pr-cidr-pool-controller
into 3ddd30f on Mellanox:main.

api/v1alpha1/cidrpool_webhook.go Outdated Show resolved Hide resolved
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@coveralls
Copy link

Coverage Status

coverage: 70.0% (-0.5%) from 70.538%
when pulling ef1e45c on ykulazhenkov:pr-cidr-pool-controller
into 3ddd30f on Mellanox:main.

@coveralls
Copy link

Coverage Status

coverage: 70.0% (-0.5%) from 70.538%
when pulling 8324b83 on ykulazhenkov:pr-cidr-pool-controller
into 3ddd30f on Mellanox:main.

@ykulazhenkov ykulazhenkov merged commit 9531cf5 into Mellanox:main Jun 11, 2024
9 checks passed
@ykulazhenkov ykulazhenkov deleted the pr-cidr-pool-controller branch June 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants