-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIDRPool 2/x] Add controller for CIDRPool CRD #42
Merged
ykulazhenkov
merged 2 commits into
Mellanox:main
from
ykulazhenkov:pr-cidr-pool-controller
Jun 11, 2024
Merged
[CIDRPool 2/x] Add controller for CIDRPool CRD #42
ykulazhenkov
merged 2 commits into
Mellanox:main
from
ykulazhenkov:pr-cidr-pool-controller
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
changed the title
Add controller for CIDRPool CRD
[CIDRPool 2/x] Add controller for CIDRPool CRD
Jun 10, 2024
vasrem
reviewed
Jun 10, 2024
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 10, 2024 16:07
c6a80a2
to
8693daf
Compare
ykulazhenkov
commented
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasrem Thanks again for the reviews. I think I addressed all comments in this PR. Please, take another look
vasrem
approved these changes
Jun 11, 2024
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 11, 2024 07:42
8693daf
to
803489b
Compare
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 11, 2024 08:12
803489b
to
e3b3483
Compare
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 11, 2024 09:35
e3b3483
to
f8465ca
Compare
rollandf
approved these changes
Jun 11, 2024
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 11, 2024 11:31
f8465ca
to
ef1e45c
Compare
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-cidr-pool-controller
branch
from
June 11, 2024 11:38
ef1e45c
to
8324b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains implementation for CIDRPool controller