Lag suffix, can be applied to an emote to save space #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use it one one emote to save space
jbpratt
reviewed
Jul 5, 2019
jbpratt
requested changes
Jul 5, 2019
WhiteNervosa
changed the title
WhiteNervosa
changed the title
|
I just now understood what JBPratt meant #82 , I'll split all of these into separate branches so its easier for you guys later today. I'm learning Git, my apologies. |
WhiteNervosa
changed the title
kenany
approved these changes
Jul 7, 2019
|
I personally generally dislike taking the main meme of an existing emote and generifying it (as e.g. with @jbpratt78 your changes were addressed? Also, is the timing the same as currently on |
|
@xDashh yep, looks good. I agree on the concern but am down to try it out. |
|
@jbpratt78 you should be able to approve and merge (if it makes sense to merge this before others, I'm not sure) |
jbpratt
approved these changes
Jul 7, 2019
|
Merged, thank you! |
SmCTwelve
pushed a commit
to SmCTwelve/chat-gui
that referenced
this pull request
Jul 8, 2019
* Lag Suffix implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lag suffix can be changed to just be an emote animation on one frame to save space