bug fixes and legacy cleanup #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abeous
commented
Jun 9, 2020
•
Abeous
commented
- fixed context menu overflow mentioned in context menu #228 https://i.imgur.com/WZZmExI.png
- now shows upward when opened in lower third of chat
- added custom tag info into tag commands descriptions
- commented out /stalk and /mentions
- commands can still be entered but will not show up in autocomplete or /help
- added context menu information to hints
- added custom tag info to hints
jbpratt
requested changes
Jun 9, 2020
assets/chat/js/chat.js
Outdated
| alias: ["m"] | ||
| } | ||
| ], | ||
| // Disabling /stalk and /mentions until functionality is added. |
There was a problem hiding this comment.
Go ahead and delete this stuff since it’s deleted above
assets/chat/js/chat.js
Outdated
| ).into(this); | ||
| } else { | ||
| MessageBuilder.info( | ||
| `No tagged nicks. Available colors: ${tagcolors.join(",")}` | ||
| `No tagged nicks. Preset colors: ${tagcolors.join(",")}, or /tag user #HEXCODE` |
There was a problem hiding this comment.
Can these be pulled out into variables as it looks like this is below as well
assets/chat/js/chat.js
Outdated
| @@ -1882,11 +1880,11 @@ class Chat { | |||
| MessageBuilder.info( | |||
| `Tagged nicks: ${[...this.taggednicks.keys()].join( | |||
| "," | |||
| )}. Available colors: ${tagcolors.join(",")}` | |||
| )}. Preset colors: ${tagcolors.join(",")}, or \`/tag user #HEXCODE\`` | |||
|
Went ahead and gutted /stalk and /mentions command functions as well. I looked around and didn't find many other commands that warranted a global variable for command strings, so I added constants within the functions to clean it up a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.