Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #66 #161

Merged
merged 1 commit into from
May 5, 2023
Merged

fix #66 #161

merged 1 commit into from
May 5, 2023

Conversation

fb-elong
Copy link
Collaborator

@fb-elong fb-elong commented May 5, 2023 •
edited
Loading

using proper height from RTF file for html output to address issue in #66 .

My development environment did not have libreoffice, so I only check with existing output.

Need help to

  1. check locally for the full flow.
  2. update all html output
  3. pass all testing cases.

@fb-elong
fix #66
b7b1b1c 
using proper height from RTF file for html output
nanxstats
nanxstats approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For today, I will just approve and merge this as the solution looks good.

The remaining things listed are generally "high effort, low impact" stuff so I doubt if anyone would have the bandwidth to do them.

@nanxstats nanxstats merged commit 03ff53b into master May 5, 2023
@nanxstats nanxstats deleted the 66-html-height branch May 5, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

@BrianLang BrianLang Awaiting requested review from BrianLang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fb-elong @nanxstats