Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support globs for reload/restart actions #138

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

9999years
Copy link
Member

@9999years 9999years commented Oct 9, 2023

Instead of supplying paths to reload for and paths to restart for (and maybe some extra extensions to restart for), this lets you use standard glob expressions to indicate paths to restart, reload, or ignore.

This will close out several tickets.

@linear
Copy link

linear bot commented Oct 9, 2023

DUX-1391 Globs for includes/excludes

It would be nice to be able to specify globs for:

  • Changes to reload on
  • Changes to restart on

Relevant crates: glob, globset, ignore

This was referenced Oct 9, 2023
@9999years
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Oct 9, 2023
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch 2 times, most recently from 59a59d1 to 3cae9f2 Compare October 9, 2023 20:09
@9999years 9999years force-pushed the rebeccat/dux-1386-async-child-process branch from 70dbca5 to b86301e Compare October 9, 2023 20:13
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch from 3cae9f2 to f4e8b16 Compare October 9, 2023 20:13
@9999years 9999years force-pushed the rebeccat/dux-1386-async-child-process branch from b86301e to 6c43fa0 Compare October 9, 2023 20:18
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch from f4e8b16 to 5e48a8c Compare October 9, 2023 20:19
@9999years 9999years force-pushed the rebeccat/dux-1386-async-child-process branch from 6c43fa0 to fa78c7f Compare October 9, 2023 20:20
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch 3 times, most recently from 407bd12 to 79633fd Compare October 9, 2023 20:23
@9999years 9999years force-pushed the rebeccat/dux-1386-async-child-process branch from fa78c7f to bddd83b Compare October 16, 2023 21:25
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch from 79633fd to 6c298b2 Compare October 16, 2023 21:25
Base automatically changed from rebeccat/dux-1386-async-child-process to main October 31, 2023 19:22
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch from 6c298b2 to aee995e Compare October 31, 2023 19:28
This replaces `--watch-restart` and `--watch-extension` with
`--restart-glob` and `--reload-glob`.
@9999years 9999years force-pushed the rebeccat/dux-1391-globs-for-includesexcludes branch from aee995e to 95d2c57 Compare November 1, 2023 18:18
@9999years 9999years marked this pull request as ready for review November 1, 2023 18:29
Copy link
Contributor

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to modify is_haskell_source_file otherwise all emacs users everywhere will need to specify a custom glob, which isn't great UX. Otherwise looks great!

src/ghci/mod.rs Show resolved Hide resolved
tests/globs.rs Outdated Show resolved Hide resolved
tests/globs.rs Outdated Show resolved Hide resolved
tests/globs.rs Outdated Show resolved Hide resolved
tests/globs.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!!!

@9999years 9999years removed the patch Bug fixes or non-functional changes label Nov 2, 2023
@9999years 9999years added the minor New functionality, non-breaking label Nov 2, 2023
@9999years 9999years merged commit cab6c61 into main Nov 2, 2023
28 checks passed
@9999years 9999years deleted the rebeccat/dux-1391-globs-for-includesexcludes branch November 2, 2023 19:52
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New functionality, non-breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants