-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support globs for reload/restart actions #138
Conversation
DUX-1391 Globs for includes/excludes
It would be nice to be able to specify globs for:
Relevant crates: |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
59a59d1
to
3cae9f2
Compare
70dbca5
to
b86301e
Compare
3cae9f2
to
f4e8b16
Compare
b86301e
to
6c43fa0
Compare
f4e8b16
to
5e48a8c
Compare
6c43fa0
to
fa78c7f
Compare
407bd12
to
79633fd
Compare
fa78c7f
to
bddd83b
Compare
79633fd
to
6c298b2
Compare
6c298b2
to
aee995e
Compare
This replaces `--watch-restart` and `--watch-extension` with `--restart-glob` and `--reload-glob`.
aee995e
to
95d2c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to modify is_haskell_source_file
otherwise all emacs users everywhere will need to specify a custom glob, which isn't great UX. Otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!!!!
Instead of supplying paths to reload for and paths to restart for (and maybe some extra extensions to restart for), this lets you use standard glob expressions to indicate paths to restart, reload, or ignore.
This will close out several tickets.