Allow customizing load-bearing sleeps #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite features a load-bearing sleep of 1 second before writing. This makes the filesystem events get detected more reliably, for whatever reason. This change allows disabling the load-bearing sleeps; this is typically needed to make several writes that all get detected together by `ghciwatch`.
Gabriella439
approved these changes
Nov 21, 2023
| @@ -477,16 +482,26 @@ impl GhciWatch { | |||
| pub fn pid(&self) -> u32 { | |||
| self.pid | |||
| } | |||
|
|
|||
| /// Get the filesystem helpers. | |||
| pub fn fs(&self) -> &Fs { | |||
There was a problem hiding this comment.
maybe make this a public field so you don't need the method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite features a load-bearing sleep of 1 second before writing. This makes the filesystem events get detected more reliably, for whatever reason.
This change allows disabling the load-bearing sleeps; this is typically needed to make several writes that all get detected together by
ghciwatch.