Fix :show targets / :show paths parsing logic
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if `:show targets` displayed a path, we would attempt to join that path to each of the module search paths and to GHCi's working directory to find the file. In reality, GHCi only checks such paths relative to its working directory. (Indeed, if you change the working directory with `:cd`, GHCi will unload all modules. [1]) Also, the logic for checking these paths was broken, considering that the search paths can be relative to the working directory, but we weren't properly joining these paths. In the future, I'll write some tests that do `--after-startup-ghci ":cd ../"` and see how much of ghciwatch explodes. [1]: https://gitlab.haskell.org/ghc/ghc/-/blob/077cb2e11fa81076e8c9c5f8dd3bdfa99c8aaf8d/compiler/GHC.hs#L1073-L1083
Gabriella439
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
:show targetsdisplayed a path, we would attempt to join that path to each of the module search paths and to GHCi's working directory to find the file.In reality, GHCi only checks such paths relative to its working directory. (Indeed, if you change the working directory with
:cd, GHCi will unload all modules. 1)Also, the logic for checking these paths was broken, considering that the search paths can be relative to the working directory, but we weren't properly joining these paths.
In the future, I'll write some tests that do
--after-startup-ghci ":cd ../"and see how much of ghciwatch explodes.