Move Ghci out of the Arc<Mutex<_>>
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #11 I removed the `Weak<Ghci>` pointers from the ghci task structs, favoring the `mpsc` channels for communication over locking a mutex. This means I can make several simplifications, in particular turning `Ghci::reload` into a real method that uses `std::mem::replace`.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 22, 2023
Closed
evanrelf
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11 I removed the
Weak<Ghci>pointers from the ghci task structs, favoring thempscchannels for communication over locking a mutex. This means I can make several simplifications, in particular turningGhci::reloadinto a real method that usesstd::mem::replace.