Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --errors for ghcid.txt #5

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

9999years
Copy link
Member

This writes stderr to an output file, clearing it between reloads.

@linear
Copy link

linear bot commented Aug 7, 2023

DUX-1229 ghcid.txt

ghcid spits out a ghcid.txt file that's used to populate Vim error lists and such. ghcid-ng should also do this.

Comment on lines -8 to -9
use clap::error::ContextKind;
use clap::error::ContextValue;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports from before CI.

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Aug 7, 2023
Comment on lines -83 to -84
/// How to display backtraces in error messages. '0' for no backtraces, '1' for standard
/// backtraces, and 'full' to display source snippets.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this argument is a ValueEnum, the possible values and their descriptions are displayed nicely in the --help output:

--backtrace <BACKTRACE>
    How to display backtraces in error messages

    [env: RUST_BACKTRACE=]
    [default: 0]

    Possible values:
    - 0:    Hide backtraces in errors
    - 1:    Display backtraces in errors
    - full: Display backtraces with all stack frames in errors

This writes stderr to an output file, clearing it between reloads.
@9999years 9999years marked this pull request as ready for review August 7, 2023 20:15
@9999years 9999years merged commit 50c958f into main Aug 7, 2023
2 checks passed
@9999years 9999years deleted the rebeccat/dux-1229-ghcidtxt branch August 7, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants