-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test harness #57
Merged
Merged
Add test harness #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2023
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 28, 2023
Merged
Merged
9999years
force-pushed
the
rebeccat/dux-1326-add-a-haskell-project
branch
from
August 28, 2023 19:07
23440e3
to
5c23795
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 19:07
68ad5e0
to
fc8f2c8
Compare
9999years
changed the base branch from
rebeccat/dux-1326-add-a-haskell-project
to
_rebeccat/dux-1332-add-tracing-event-matcher
August 28, 2023 19:45
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 19:45
fc8f2c8
to
045003c
Compare
This was referenced Aug 28, 2023
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 19:56
42da07a
to
cedfa15
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 19:56
045003c
to
37378f1
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 20:09
cedfa15
to
dcd7d3d
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 20:10
37378f1
to
7efd4e0
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 21:24
dcd7d3d
to
0225fbc
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 21:24
7efd4e0
to
0921d3a
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 22:04
0225fbc
to
b4d0fe9
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 22:04
8fdad0a
to
6cbff61
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 22:24
b4d0fe9
to
3bc1d3b
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 22:24
6cbff61
to
96d3725
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 22:43
3bc1d3b
to
6fa5f00
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 22:43
96d3725
to
47bda68
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 22:50
6fa5f00
to
50ff0cb
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 22:50
47bda68
to
faf6711
Compare
9999years
force-pushed
the
_rebeccat/dux-1332-add-tracing-event-matcher
branch
from
August 28, 2023 22:54
50ff0cb
to
f8fd033
Compare
9999years
force-pushed
the
rebeccat/dux-1327-add-test-harness
branch
from
August 28, 2023 22:54
faf6711
to
cfcc024
Compare
I had these backwards
This helps prevent zombie processes from lingering around and exhausting all of my RAM.
Gabriella439
reviewed
Sep 1, 2023
Co-authored-by: Gabriella Gonzalez <gabriella@mercury.com>
Gabriella439
previously approved these changes
Sep 1, 2023
} | ||
Some(path) => { | ||
if let Err(err) = tokio::fs::remove_dir_all(&path).await { | ||
// Run `find` on the directory so we can see what's in it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you had to make use of this fallback code path for removing the directory? In other words, has rm -rf
succeeded where remove_dir_all
failed?
Co-authored-by: Gabriella Gonzalez <gabriella@mercury.com>
Gabriella439
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GhcidNg
type copies a given directory to a tempdir and then launchesghcid-ng
there. It also spawns an async task to read JSON log events from the log file.GhcidNg
uses thread-local storage to determine which version ofghc
to use when launching tests, and will error appropriately if the thread-local storage is not set. This takes advantage of the fact that async tests run in thetokio
"current-thread" runtime by default, which schedules all tasks in the test on the same thread.The second part is a proc macro attribute exported as
#[test_harness::test]
, which rewrites tests so that#[tokio::test]
current-thread runtime.test-harness
library are visible in the test output.ghcid-ng
logs are saved to a directory undertarget/
and the path is printed at the end of the tests.Here's a sample test from #44 using this test harness: