Parse shell command arguments #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
rebeccat/clonable-command
branch
3 times, most recently
from
8eadfbe
to
b7836f3
Compare
9999years
force-pushed
the
rebeccat/clonable-command
branch
from
b7836f3
to
f8906fa
Compare
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Merged
Gabriella439
previously approved these changes
Sep 6, 2023
Gabriella439
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses shell command arguments into a new
ClonableCommandstruct, which stores the program, arguments, and environment for a command to be run.I've also converted several of the more complex constructors into accepting structs instead of multiple positional arguments, which get challenging to track.