fix scoring unfinished rounds (#35)

Meridian-IE · Oct 4, 2023 · aaf1724 · aaf1724
1 parent 8c67f49
commit aaf1724
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/ImpactEvaluator.sol b/src/ImpactEvaluator.sol
@@ -101,6 +101,7 @@ contract ImpactEvaluator is AccessControl {
             addresses.length == scores.length,
             "Addresses and scores length mismatch"
         );
+        require(roundIndex < currentRoundIndex(), "Round not finished");
         Round storage round = rounds[roundIndex];
         require(round.exists, "Round does not exist");
         require(!round.scoresSubmitted, "Scores already submitted");

diff --git a/test/ImpactEvaluator.t.sol b/test/ImpactEvaluator.t.sol
@@ -166,6 +166,14 @@ contract ImpactEvaluatorTest is Test {
         impactEvaluator.setScores(0, addresses, scores, "0 tasks performed");
     }
 
+    function test_SetScoresUnfinishedRound() public {
+        ImpactEvaluator impactEvaluator = new ImpactEvaluator(address(this));
+        address payable[] memory addresses = new address payable[](0);
+        uint64[] memory scores = new uint64[](0);
+        vm.expectRevert("Round not finished");
+        impactEvaluator.setScores(0, addresses, scores, "0 tasks performed");
+    }
+
     function test_CurrentRoundMeasurementCount() public {
         ImpactEvaluator impactEvaluator = new ImpactEvaluator(address(this));
         assertEq(impactEvaluator.currentRoundMeasurementCount(), 0);