Log warnings when compiling if a script name doesn't match the file name

- Unity requires that the script name matches the file name exactly in order for many editor features to work as expected. It's broken to the point that I don't think I can just work around it without other odd issues.
MerlinVR · Dec 11, 2020 · f4125e7 · f4125e7
1 parent c923fdb
commit f4125e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Assets/UdonSharp/Editor/UdonSharpCompilationModule.cs b/Assets/UdonSharp/Editor/UdonSharpCompilationModule.cs
@@ -165,7 +165,6 @@ public CompileTaskResult Compile(List<ClassDefinition> classDefinitions, Microso
                     debugInfo.FinalizeDebugInfo();
 
                 UdonSharpEditorCache.Instance.SetDebugInfo(programAsset, isEditorBuild ? UdonSharpEditorCache.DebugInfoType.Editor : UdonSharpEditorCache.DebugInfoType.Client, debugInfo);
-                //programAsset.debugInfo = debugInfo;
             }
 
             return result;

diff --git a/Assets/UdonSharp/Editor/UdonSharpCompiler.cs b/Assets/UdonSharp/Editor/UdonSharpCompiler.cs
@@ -378,6 +378,12 @@ List<ClassDefinition> BindPrograms(List<(UdonSharpProgramAsset, Microsoft.CodeAn
                 if (bindResult.compileErrors.Count == 0)
                 {
                     classDefinitions.Add(bindResult.classDefinition);
+
+                    if (bindResult.sourceScript.GetClass() == null && 
+                        bindResult.classDefinition.userClassType.Name != Path.GetFileNameWithoutExtension(AssetDatabase.GetAssetPath(bindResult.sourceScript)))
+                    {
+                        Debug.LogWarning($"[<color=#FF00FF>UdonSharp</color>] {AssetDatabase.GetAssetPath(bindResult.sourceScript)}: Class name does not match file name, Unity requires that both names match exactly for the editor to work properly.", bindResult.sourceScript);
+                    }
                 }
                 else
                 {