Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIN security and Face/Touch ID Authentication to wallet #5

Open
6 of 7 tasks
satindergrewal opened this issue May 18, 2021 · 1 comment
Open
6 of 7 tasks
Assignees
Labels
enhancement New feature or request phase 1 Needed for first initial production release
Milestone

Comments

@satindergrewal
Copy link
Member

satindergrewal commented May 18, 2021

So far I observed the wallet just opens up and we can continue with our regular wallet operations.

There needs to be a Wallet security like inputting PIN to open a wallet and steps like conforming the PIN before sending transaction.

The simpler examples can be like Mycelium.

Much better examples can be AtomicDEX mobile app. You can just test it and experience it's user interface and we can learn and adapt much from them in our application.

  • PIN security
  • Face ID and Touch ID authentication for login

Places where this authentication is needed:

  • Login Screen
  • Confirm Payment Screen
  • Recover Seed Phrase
  • When enabled or disabled Face/Touch ID from Settings
  • Change/Update PIN to new PIN

Additional security for PIN security feature:

The number pad for entering PIN should be showing the numbers at random location. Example:

1	2	3
4	5	6
7	8	9
	0

Shows randomly everytime the app prompts the input PIN option. Like:

9	6	0
7	1	8
3	5	2
	4
@satindergrewal satindergrewal added the enhancement New feature or request label May 18, 2021
@satindergrewal satindergrewal changed the title Add PIN security to wallet Add PIN security and Face/Touch ID Authentication to wallet May 18, 2021
@satindergrewal satindergrewal added this to the Release v1.0 milestone May 24, 2021
@satindergrewal satindergrewal added the phase 1 Needed for first initial production release label May 27, 2021
@lastw0nd3r
Copy link
Collaborator

Implemented PIN based logic. Next should be Biometric/TouchID based logic.

satindergrewal pushed a commit that referenced this issue Jul 14, 2021
Fix issue #5 TransactionEncoderError 5 when shielding funds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request phase 1 Needed for first initial production release
Projects
None yet
Development

No branches or pull requests

2 participants