Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging intermittent failure fix and enhancement by capturing memory stats #48

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

cpelley
Copy link
Collaborator

@cpelley cpelley commented Jul 12, 2024

  • Record plugin step memory footprint to the log (+sqlite.db).
  • Expose host and port number of client and server side components of the logger (pre-requisite for multi-node execution).
  • logger server now exposed as an executable script: dagrunner-logger (on pip install). Pre-requisite capability for a single logger server shared amongst any number independent graphs being executed.
  • Fix logging integration test intermittent failures (mostly seen during CI previously) and re-enable the tests run under CI.

Issues

Note

Ignore the CI failure. See comment.

@cpelley cpelley self-assigned this Jul 12, 2024
@cpelley cpelley changed the title re-enabled logger in CI and record memory footprint Enhanced logger Jul 12, 2024
@cpelley cpelley added the enhancement New feature or request label Jul 12, 2024
@cpelley cpelley changed the title Enhanced logger logger maintenance Jul 12, 2024
Comment on lines +152 to +154
if queue_handler:
queue_handler.write(self.log_queue) # Ensure all records are written
queue_handler.close()
Copy link
Collaborator Author

@cpelley cpelley Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the necessary change to avoid intermittent failures (i.e. why logging was disabled in CI).
This ensures that we write everything from the log queue before closing things down.

@cpelley
Copy link
Collaborator Author

cpelley commented Jul 15, 2024

The CI failure is to do with the reference branch (master) which still contains the bug that this PR fixes. Note that the pytest run for this branch all succeed.
image

@cpelley cpelley marked this pull request as ready for review July 15, 2024 08:59
@cpelley cpelley changed the title logger maintenance Logging maintenance and enhancement (memory stats) Jul 15, 2024
@cpelley cpelley changed the title Logging maintenance and enhancement (memory stats) Logging fix and enhancement (memory stats) Jul 15, 2024
@cpelley cpelley added the bug Something isn't working label Jul 15, 2024
@cpelley cpelley changed the title Logging fix and enhancement (memory stats) Logging intermittent failure fix and enhancement by capturing memory stats Jul 15, 2024
@cpelley cpelley merged commit bc51cdb into main Jul 15, 2024
1 of 2 checks passed
@cpelley cpelley deleted the MEMORY_FOOTPRINT branch July 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants