Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether the dst port is within the specified range #1706

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

laburaps
Copy link

@laburaps laburaps commented Dec 10, 2024

After iterating the sniffers list in TCPSniff, if there is a sniffer that meets the protocol and port requirements, then inWhitelist is set to true, and the subsequent sniffDomain process is entered. However, in sniffDomain, there is no re-check on the port, which leads to a situation where, even though both HTTP and TLS sniffers are configured to sniff different ports (for example, HTTP sniffer only sniffs port 80, and TLS sniffer only sniffs port 443), in practice, HTTP sniffer will sniff all requests on port 443 (and TLS sniffer will sniff all requests on port 80).

Solution: Simply add another check for the supported ports in sniffDomain.

@wwqgtxx wwqgtxx merged commit 5d9d8f4 into MetaCubeX:Alpha Dec 10, 2024
55 checks passed
@laburaps laburaps deleted the PR-SnifferCheckDSTPort branch December 11, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants