fix: check whether the dst port is within the specified range #1706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After iterating the sniffers list in
TCPSniff
, if there is a sniffer that meets the protocol and port requirements, theninWhitelist
is set to true, and the subsequentsniffDomain
process is entered. However, insniffDomain
, there is no re-check on the port, which leads to a situation where, even though both HTTP and TLS sniffers are configured to sniff different ports (for example, HTTP sniffer only sniffs port 80, and TLS sniffer only sniffs port 443), in practice, HTTP sniffer will sniff all requests on port 443 (and TLS sniffer will sniff all requests on port 80).Solution: Simply add another check for the supported ports in
sniffDomain
.