Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump restls to v0.1.5 (utls v1.4.3) #692

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

3andne
Copy link

@3andne 3andne commented Aug 15, 2023

Hi,
Sorry for the delay. We were working on this update throughout the entire week.
Off topic:
It turns out we were among the few projects leveraging session resumption (we don't rebuild the TLS Config per connection). This led us down many rarely traversed paths, which hadn't been tested for years. Pinpointing and resolving these issues was time-consuming.
Our efforts culminated in the introduction of a long-awaited feature in uTLS: PSK-based session resumption for TLS 1.3. We're in the final stages of our work, anticipating its integration into uTLS. Implementing the PSK feature will enhance parroting, aligning utls clients more closely with browsers, especially given that recent Chrome versions utilize PSK-based sessions for TLS 1.3.

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented Aug 15, 2023

Please do not import quic-go/quic-go in dependencies.

@3andne
Copy link
Author

3andne commented Aug 16, 2023

Please do not import quic-go/quic-go in dependencies.

The module quic-go is introduced by utls v1.4.0. It will probably be there anyways if you bump the version of utls. I'm not sure about the best practices here. Any recommendations or guidance?

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented Aug 16, 2023

Please do not import quic-go/quic-go in dependencies.

The module quic-go is introduced by utls v1.4.0. It will probably be there anyways if you bump the version of utls. I'm not sure about the best practices here. Any recommendations or guidance?

I took a look at the code. In fact, only quicvarint.Append() is used in u_quic_transport_parameters.go, so you can easily place quicvarint.Append() inside the restls-client-go project ( https://github.com/quic-go/quic-go/blob/v0.37.4/quicvarint/varint.go#L73-L91 ), which removes the dependency on quic-go.

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented Aug 16, 2023

maybe you can merge 3andne/restls-client-go#4

@3andne
Copy link
Author

3andne commented Aug 16, 2023

maybe you can merge 3andne/restls-client-go#4

Wow, nice work. Sorry I didn't see that, but thanks anyways. I have updated and removed the go-quic dependency.

@wwqgtxx wwqgtxx merged commit 03b0252 into Alpha Aug 16, 2023
@wwqgtxx wwqgtxx deleted the bump-restls-version branch August 16, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants