Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @metamask/eth-sig-util types #248

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix @metamask/eth-sig-util types #248

merged 1 commit into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. Fix @metamask/eth-sig-util types

    The types for the package `@metamask/eth-sig-util` were being
    overwritten by a local type declaration. That has been removed, and all
    type errors have been resolved.
    
    All of the type errors were related to `normalize` returning
    `undefined` if given a nullish input. We never pass it a nullish input,
    but TypeScript wasn't able to infer that, so that issue was addressed
    with type casts. This isn't ideal, but it's temporary. Once we finish
    migrating all Keyrings to the new Keyring interface, we won't need to
    normalize addresses anymore at all.
    Gudahtt committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6e3fdfb View commit details
    Browse the repository at this point in the history