SIP-28: Background Events #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Oct 9, 2024
Mrtenz
reviewed
Oct 9, 2024
Mrtenz
reviewed
Oct 9, 2024
Mrtenz
reviewed
Oct 9, 2024
|
|
||
| The RPC method takes two parameters: | ||
|
|
||
| - `date` - An [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) date and time and optional timezone offset. |
There was a problem hiding this comment.
Is date preferred to letting the caller specify a number of seconds or something?
Wondering what is the simplest for developers.
There was a problem hiding this comment.
- Notice that we have minute rather than second level precision.
- Conversion to ISO strings is a single call to
date.toISOString(). - What happens to seconds when daylight time change happens?
- What happens to seconds when user travels between timezones. local-time vs UTC distinction is an edge case here, where local-time changes while UTC one doesn't
SIPS/sip-28.md
Outdated
|
|
||
| ### Snap Manifest | ||
|
|
||
| This SIP introduces a new permission `endowment:background-events`. This permissions grants a Snap the ability to schedule future events. |
There was a problem hiding this comment.
Wondering if we should somehow merge this with cronjobs 🤔 Otherwise, we'll have two permissions that do extremely similar things 😄
There was a problem hiding this comment.
You mean like using endowment:cronjobs and just allowing two new RPC methods? Your call - I'm okay with either way.
There was a problem hiding this comment.
I think we eventually want to rename cronjobs to background events, but doing so will be a breaking change.
Mrtenz
reviewed
Oct 10, 2024
Mrtenz
reviewed
Oct 10, 2024
Mrtenz
reviewed
Oct 10, 2024
Mrtenz
reviewed
Oct 10, 2024
FrederikBolding
approved these changes
Oct 11, 2024
Mrtenz
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a SIP that allows a developer to schedule one-off events in the future.