Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add qr keyring package #60

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add qr keyring package #60

wants to merge 1 commit into from

Conversation

mikesposito
Copy link
Member

This is a WIP implementation of a Keyring compatible with Keystone QR hardware

Examples

@danroc
Copy link
Contributor

danroc commented Sep 25, 2024

Thank you @mikesposito! Maybe we should import this using git merge --allow-unrelated-histories (+ manual fixes) to keep the history from the original repo.

@mikesposito
Copy link
Member Author

mikesposito commented Sep 25, 2024

@danroc this PR is not moving the package from another source - this is a new implementation, and only shares a similar account derivation strategy from URs with the original keyring package currently used on clients

Do you think we should bring in its commit history anyway? Also, the package is in a Keystone monorepo, which would include commits to other packages potentially unrelated

@danroc
Copy link
Contributor

danroc commented Sep 25, 2024

Sorry @mikesposito, I didn't realise it was a new implementation! In this case it makes sense to start fresh, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants