fix: export JsonRpcRequest + remove imports from dist folder
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
previously approved these changes
Nov 13, 2024
gantunesr
previously approved these changes
Nov 13, 2024
danroc
previously approved these changes
Nov 13, 2024
danroc
reviewed
Nov 13, 2024
packages/keyring-snap-bridge/src/KeyringSnapControllerClient.ts
Outdated
Show resolved
Hide resolved
ccharly
force-pushed
the
fix/export-keyring-internal-types
branch
from
23b197c
to
f258e21
Compare
danroc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JsonRpcRequesttype was used in the bridge but not "officially" exported by thekeyring-api(hence the import from thedistfolder).To avoid this pattern, we now export it properly.