-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.0 #131
3.1.0 #131
Conversation
CHANGELOG.md
Outdated
- Allow prerelease versions in release headers ([#130](https://github.com/MetaMask/auto-changelog/pull/130)) | ||
|
||
### Changed | ||
- Check for `code` property when interpreting filesystem errors ([#124](https://github.com/MetaMask/auto-changelog/pull/124)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is worth noting or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I think the only functional difference is that if a primitive type is thrown, we now re-throw it rather than crashing again when trying to check the code
property. Otherwise it should be functionally identical. We were checking the code
property before, just not verifying that the error was an error before checking.
I'd probably remove it or re-word it to reflect the functional impact it has, but it's not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's a good point. I was leaning toward removing this; it's kind of hard to explain, and I don't think people are likely to run into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added