Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0 #167

Merged
merged 7 commits into from
Oct 19, 2023
Merged

3.4.0 #167

merged 7 commits into from
Oct 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 3.4.0.

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/auto-changelog@3.3.0

@kanthesha kanthesha marked this pull request as ready for review October 17, 2023 18:21
@kanthesha kanthesha requested a review from a team as a code owner October 17, 2023 18:21
CHANGELOG.md Outdated
@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [3.4.0]
### Added
- Allow to retain tags history in case of renamed packages ([#157](https://github.com/MetaMask/auto-changelog/pull/157))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a proposal for the commit

  • Retain tag history for renamed packages with new validation options (#157)

    • Introduced --version-before-package-rename and --tag-prefix-before-package-rename options for validate command.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

CHANGELOG.md Outdated Show resolved Hide resolved
@kanthesha kanthesha requested a review from mcmire October 18, 2023 12:08
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kanthesha kanthesha merged commit 320f359 into main Oct 19, 2023
19 checks passed
@kanthesha kanthesha deleted the release/3.4.0 branch October 19, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants