Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @metamask/utils from devDeps to deps #168

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

legobeat
Copy link
Contributor

https://github.com/MetaMask/utils/actions/runs/6601251324/job/17932102826?pr=152

node:internal/modules/cjs/loader:1051
  throw err;
  ^

Error: Cannot find module '@metamask/utils'
Require stack:
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/init.js
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/cli.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js:18:17)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js',
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/init.js',
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/cli.js'
  ]
}

- Was added as devDependency while importing in runtime in MetaMask#158.
@legobeat legobeat marked this pull request as ready for review October 23, 2023 06:58
@legobeat legobeat requested a review from a team as a code owner October 23, 2023 06:58
@legobeat legobeat added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 23, 2023
@legobeat legobeat merged commit de71b88 into MetaMask:main Oct 23, 2023
19 checks passed
@mcmire
Copy link
Contributor

mcmire commented Oct 24, 2023

@legobeat Hmm... this doesn't seem right. This isn't a development dependency; it legitimately is used in this package. So wouldn't this break normal usage of this package on the command line? For instance, if you were to just call this via yarn dlx @metamask/auto-changelog or npx @metamask/auto-changelog, it wouldn't work.

Wow, I misread this PR title. Apologies. This is definitely right, not sure how we missed this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants