@metamask/eslint config@6.0.0 #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gudahtt
reviewed
Apr 14, 2021
.eslintrc.js
Outdated
| 'error', | ||
| { | ||
| resolves: 'Use `expect(await promise)` instead.', | ||
| // 'toBeFalsy': 'Avoid `toBeFalsy`', |
There was a problem hiding this comment.
Ah I see, these are restricted matchers in our config that we use here? Maybe worth adding a comment explaining this
Gudahtt
reviewed
Apr 14, 2021
Gudahtt
reviewed
Apr 14, 2021
rekmarks
force-pushed
the
@metamask/eslint-config@6.0.0
branch
2 times, most recently
from
7d1e059
to
76eb3f2
Compare
rekmarks
force-pushed
the
@metamask/eslint-config@6.0.0
branch
from
76eb3f2
to
0db3170
Compare
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
rekmarks
force-pushed
the
@metamask/eslint-config@6.0.0
branch
from
0db3170
to
6baa86d
Compare
Gudahtt
added a commit
that referenced
this pull request
Apr 15, 2021
- Add restricted controller messenger ([#378](#378)) - **BREAKING:** Update minimum Node.js version to v12 ([#441](#441)) - **BREAKING:** Replace controller context ([#387](#387)) - Bump @metamask/contract-metadata from 1.23.0 to 1.24.0 ([#440](#440)) - Update lint rules ([#442](#442), [#426](#426)) - Don't remove collectibles during auto detection ([#439](#439))
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* @metamask/eslint*config@6.0.0 * Make necessary package updates and changes to .eslintrc.js. * Remove lint*staged dependency * Remove the local Prettier config * Remove rules made redundant by new config * Update the CI config and package scripts. * The `format` scripts and CI job were removed since formatting is now done during the lint script. * Only extend Jest rules for test files, update Jest rules * Replace "toEqual" with "toStrictEqual" in tests * Replace Jest "resolves" matchers with config-permitted equivalents * Run `yarn lint:fix` and replace `toEqual` with `toStrictEqual` in tests.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* @metamask/eslint*config@6.0.0 * Make necessary package updates and changes to .eslintrc.js. * Remove lint*staged dependency * Remove the local Prettier config * Remove rules made redundant by new config * Update the CI config and package scripts. * The `format` scripts and CI job were removed since formatting is now done during the lint script. * Only extend Jest rules for test files, update Jest rules * Replace "toEqual" with "toStrictEqual" in tests * Replace Jest "resolves" matchers with config-permitted equivalents * Run `yarn lint:fix` and replace `toEqual` with `toStrictEqual` in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
@metamask/eslint-config@6.0.0and sibling packages from that major version. As you can see, the diff is enormous. However, most of the changes are programmatic and contained within single commits, so reviewing won't be as bad as it looks.The end result of this effort is to bring this repository onto the same lint standards as everywhere else in the organization. The package's own
prettierconfig is removed.Changes prefixed with "❗" required manual fixing and deserve extra attention.
.eslintrc.jsjestrules for every file, and moves them into an override targeting test files only.formatscripts and CI job are removed since formatting is now done duringlint.yarn lint:fixand replacetoEqualwithtoStrictEqualin tests.toEqualwere left over after the rebase. They're fixed fdec723.toStrictEqual.jest.resolvesmatchers.jestrules and move them to the override added in 5b4957c.lint-stagedand the localprettierconfig.yarn lint:fixto fix all prettier violations following the removal of the localprettierconfig.toEqualinstances withtoStrictEqual.